Fix macOS @rpath install-name id for ros_type_introspection - #564
Merged
traversaro merged 3 commits intoJul 21, 2026
Conversation
The dylib was built with a bare install-name id
('libros_type_introspection.dylib') because the old
cmake_minimum_required leaves policy CMP0042 = OLD (MACOSX_RPATH off).
Consumers then record the bare dependency name and dyld cannot resolve
it from the environment lib dir, so all plotjuggler-ros plugins
(DataLoadROS / DataStreamROS / RosTopicPublisher) fail to dlopen on
osx-64 and osx-arm64 -- PlotJuggler ends up with no .bag loader.
Set CMAKE_MACOSX_RPATH ON so the library advertises an
@rpath/libros_type_introspection.dylib install name. This fixes all
consumers at the source. No-op on Linux/Windows.
Added ros_type_introspection with build number.
Collaborator
|
LGTM, thanks. What do you think @traversaro? |
Tobias-Fischer
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this great project!
I tested loading a ros1 .bag into plotjuggler from a ros-noetic-plotjuggler-ros mamba install and got the following on macOS:
Plotjuggler application opened as normal, but it did not allowing us to open a .bag
The dylib was built with a bare install-name id
('libros_type_introspection.dylib') because the old cmake_minimum_required leaves policy CMP0042 = OLD (MACOSX_RPATH off). Consumers then record the bare dependency name and dyld cannot resolve it from the environment lib dir, so all plotjuggler-ros plugins (DataLoadROS / DataStreamROS / RosTopicPublisher) fail to dlopen on osx-64 and osx-arm64 -- PlotJuggler ends up with no .bag loader.
Set CMAKE_MACOSX_RPATH ON so the library advertises an @rpath/libros_type_introspection.dylib install name. This fixes all consumers at the source. No-op on Linux/Windows.